Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.09.18 at 10:24, <wei.liu2@xxxxxxxxxx> wrote:
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -91,7 +91,8 @@ static uint32_t conringc, conringp;
>  static int __read_mostly sercon_handle = -1;
>  
>  #ifdef CONFIG_X86
> -static bool __read_mostly opt_console_xen; /* console=xen */
> +/* Set to true at start of day to catch early boot issues */
> +static bool __read_mostly opt_console_xen = true; /* console=xen */

When Andrew suggested this, iirc he said to make the variable
tristate. Otherwise ...

> @@ -821,6 +822,10 @@ void __init console_init_preirq(void)
>  
>      serial_init_preirq();
>  
> +#ifdef CONFIG_X86
> +    opt_console_xen = false;
> +#endif

... you possibly override a user specified "true" here.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel