Re: [Xen-devel] [PATCH 2/2] xen: make opt_xen_console true before console initialisation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 28, 2018 at 05:19:50PM +0100, Wei Liu wrote:
> On Fri, Sep 28, 2018 at 10:05:21AM -0600, Jan Beulich wrote:
> > >>> On 28.09.18 at 17:53, <wei.liu2@xxxxxxxxxx> wrote:
> > > At the moment the ordering of the options matter, which means if "xen"
> > > is not the first option we can lose output.
> > > 
> > > I think one easy way of improving is to parse opt_console twice. The
> > > first time solely looks for "xen" and the second time parses the rest
> > > options.
> > 
> > What's wrong with making the variable a tristate, and move your
> > set-to-false after the parsing loop? If the user said "false" for the
> > option, then they apparently don't care much about the output.
> 
> Oh, there is nothing wrong with that. It just I didn't think about that
> solution while thinking about this problem.
> 
> > 
> > But yes, what you suggest is an option as well.
> 
> Yeah, I already got code for it.

After fixing the bugs in my code it has become too long for my liking so
I will turn to use tristate instead. :p

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel