Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.18 at 12:27, <Paul.Durrant@xxxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Roger Pau Monne [mailto:roger.pau@xxxxxxxxxx]
>> Sent: 08 October 2018 11:15
>> To: xen-devel@xxxxxxxxxxxxxxxxxxxx 
>> Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>; Jan Beulich
>> <jbeulich@xxxxxxxx>; Paul Durrant <Paul.Durrant@xxxxxxxxxx>
>> Subject: [PATCH] x86/vtd: fix iommu_share_p2m_table
>> 
>> Commit 2916951c1 changed the check in iommu_share_p2m_table to use
>> need_iommu(d) instead of iommu_enabled, which broke the check because
>> at the point in domain construction where iommu_share_p2m_table is
>> called need_iommu(d) will always return false.
>> 
>> Fix this by reverting to the previous logic.
> 
> Thanks for finding this.
> 
> Above, I think you need to include the title of commit 2916951c1 and also 
> the text should say that the need_iommu() check became implicit in 
> iommu_hap_pt_share() (otherwise folks looking at the patch may be bemused 
> because need_iommu is not in the code).

Indeed, it did take me more than just a moment to make the
connection between description and code change (in this
regard).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel