Re: [Xen-devel] [PATCH] x86/vtd: fix iommu_share_p2m_table

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 08, 2018 at 04:33:04AM -0600, Jan Beulich wrote:
> >>> On 08.10.18 at 12:14, <roger.pau@xxxxxxxxxx> wrote:
> > --- a/xen/drivers/passthrough/iommu.c
> > +++ b/xen/drivers/passthrough/iommu.c
> > @@ -505,7 +505,7 @@ int iommu_do_domctl(
> >  
> >  void iommu_share_p2m_tableiommu_share_p2m_table(struct domain* d)
> >  {
> > -    if ( iommu_use_hap_pt(d) )
> > +    if ( iommu_enabled && hap_enabled(d) && iommu_hap_pt_share )
> 
> Considering the only caller, the hap_enabled() part is (and was) not
> needed here.

Would you like me to remove it in this patch?

I've merely changed iommu_share_p2m_table back to use the same logic
as before 2916951c1.

> I also would prefer to see a comment attached here,
> to (briefly) explain why this can't be iommu_use_hap_pt().
> 
> Is this what Wei also has found to break his PVH Dom0?

Yes, I think so.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel