Re: [Xen-devel] [PATCH v5 13/25] xen/arm: move unregister_init_virtual_region to init_done

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 23/10/2018 03:02, Stefano Stabellini wrote:
> Move unregister_init_virtual_region to init_done. Follow the same path
> as x86. It is also useful to move it later so that create_domUs can be
> called before that in following patches.
>
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>
Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> ---
>   xen/arch/arm/setup.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 49f2fef..f3dc96c 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -66,6 +66,9 @@ integer_param("xenheap_megabytes", opt_xenheap_megabytes);
>   
>   static __used void init_done(void)
>   {
> +    /* Must be done past setting system_state. */
> +    unregister_init_virtual_region();
> +
>       free_init_memory();
>       startup_cpu_idle_loop();
>   }
> @@ -955,9 +958,6 @@ void __init start_xen(unsigned long boot_phys_offset,
>   
>       system_state = SYS_STATE_active;
>   
> -    /* Must be done past setting system_state. */
> -    unregister_init_virtual_region();
> -
>       domain_unpause_by_systemcontroller(dom0);
>   
>       /* Switch on to the dynamically allocated stack for the idle vcpu
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel