Re: [Xen-devel] [PATCH 3/8] viridian: remove comments referencing section number in the spec.

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Oct 29, 2018 at 06:02:06PM +0000, Paul Durrant wrote:
> Microsoft has a habit of re-numbering sections in the spec. so avoid
> referring to section numbers in comments. Also remove the URL for the
> spec. from the boilerplate... Again, Microsoft has a habit of changing
> these too.
> 
> This patch also cleans up some > 80 character lines.
> 
> Purely cosmetic. No functional change.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just one nit below.

> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/viridian/viridian.c | 82 
> ++++++++++++++++--------------------
>  xen/include/asm-x86/hvm/viridian.h   |  4 --
>  2 files changed, 36 insertions(+), 50 deletions(-)
> 
> diff --git a/xen/arch/x86/hvm/viridian/viridian.c 
> b/xen/arch/x86/hvm/viridian/viridian.c
> index c5722d6992..db166d41c5 100644
> --- a/xen/arch/x86/hvm/viridian/viridian.c
> +++ b/xen/arch/x86/hvm/viridian/viridian.c
> @@ -1,12 +1,8 @@
> -/******************************************************************************
> +/**************************************************************************
>   * viridian.c
>   *
>   * An implementation of some Viridian enlightenments. See Microsoft's
> - * Hypervisor Top Level Functional Specification (v5.0a) at:
> - *
> - * 
> https://github.com/Microsoft/Virtualization-Documentation/raw/master/tlfs/Hypervisor%20Top%20Level%20Functional%20Specification%20v5.0.pdf
> - *
> - * for more information.
> + * Hypervisor Top Level Functional Specification for more information.
>   */
>  
>  #include <xen/sched.h>
> @@ -103,10 +99,7 @@
>  #define HV_FLUSH_ALL_PROCESSORS 1
>  
>  /*
> - * Viridian Partition Privilege Flags.
> - *
> - * This is taken from section 4.2.2 of the specification, and fixed for
> - * style and correctness.
> + * Viridian Partition Privilege Flags
>   */

This being a single line comment now should be /* ... */.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel