Re: [Xen-devel] [PATCH v5 03/24] hw: acpi: The RSDP build API can return void

[Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>]

On Tue, Nov 06, 2018 at 11:23:39AM +0100, Paolo Bonzini wrote:
> On 05/11/2018 02:40, Samuel Ortiz wrote:
> >  /* RSDP */
> > -static GArray *
> > +static void
> >  build_rsdp(GArray *rsdp_table, BIOSLinker *linker, unsigned 
> > xsdt_tbl_offset)
> >  {
> >      AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
> > @@ -392,8 +392,6 @@ build_rsdp(GArray *rsdp_table, BIOSLinker *linker, 
> > unsigned xsdt_tbl_offset)
> >      bios_linker_loader_add_checksum(linker, ACPI_BUILD_RSDP_FILE,
> >          (char *)rsdp - rsdp_table->data, sizeof *rsdp,
> >          (char *)&rsdp->checksum - rsdp_table->data);
> > -
> > -    return rsdp_table;
> >  }
> >  
> 
> Better than v4. :)
Right, I followed Philippe's advice and it does make things clearer :)

Cheers,
Samuel.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel