[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 8/8] tools/libvchan: libxenvchan_client_init: use ENOENT for no server

Marek Marczykowski-Górecki writes ("Re: [PATCH 8/8] tools/libvchan: 
libxenvchan_client_init: use ENOENT for no server"):
> On Tue, Nov 06, 2018 at 11:45:47AM +0000, Ian Jackson wrote:
> > Right.  Marek, this series was intended to help with vchan for qmp.
> > But obviously I don't want to break anything else.  I don't think this
> > should break anything but I would appreciate a review or at least an
> > opinion...
> Does xentoollog require any explicit configuration? If yes, that would
> break non-xen-tools users (including Qubes). Otherwise looks good.
> Thanks!


libvchan already takes an xtl logger as an argument, and passes that
on to lower-layer libraries.  So it's already in there.  The only
difference is that it is used directly by libchan now.

But I tried to make an argument that the new log message could cause
no problem and I think that's actually wrong.  libvchan right now
passes that logger to xengntshr_open and xenevtchn_open, but those
both tolerate NULL (and make up their own logger which writes to

But with my change, NULL will cause a crash if new error condition


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.