Re: [Xen-devel] [PATCH 06/14] x86/hvm: Make the altp2m locking easier to follow

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.11.18 at 14:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> Drop the ap2m_active boolean, and consistently use the unlocking form:
> 
>   if ( p2m != hostp2m )
>        __put_gfn(p2m, gfn);
>   __put_gfn(hostp2m, gfn);
> 
> which makes it clear that we always unlock the altp2m's gfn if it is in use,
> and always unlock the hostp2m's gfn.  This also drops the ternary expression
> in the logdirty case.
> 
> Extend the logdirty comment to identify where the locking violation is liable
> to occur.
> 
> No (intended) overall change in behaviour.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit I think the title could do with some improvement: As it stands
it reads as if you do an altp2m-global change, but it's all limited to
hvm_hap_nested_page_fault().

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel