Re: [Xen-devel] [PATCH 07/14] x86/p2m: Coding style cleanup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.11.18 at 14:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -776,7 +776,7 @@ guest_physmap_add_entry(struct domain *d, gfn_t gfn, 
> mfn_t mfn,
>                                &a, 0, NULL, NULL);
>          if ( p2m_is_shared(ot) )
>          {
> -            /* Do an unshare to cleanly take care of all corner 
> +            /* Do an unshare to cleanly take care of all corner
>               * cases. */

Please leave a well formed comment if you already touch it in a patch
with this kind of a title. Same further down. Interestingly enough you
do so in p2m.h. With this
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel