Re: [Xen-devel] [PATCH 06/25] argo: Xen command line parameter 'argo': bool to enable/disable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.18 at 02:32, <christopher.w.clark@xxxxxxxxx> wrote:
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -28,6 +28,10 @@
>  DEFINE_XEN_GUEST_HANDLE(argo_addr_t);
>  DEFINE_XEN_GUEST_HANDLE(argo_ring_t);
>  
> +/* Xen command line option to enable argo */
> +static bool __read_mostly opt_argo_enabled = 0;

The initializer is pointless here, and if there was one then it
should be true or false.

> @@ -223,6 +227,13 @@ do_argo_message_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) 
> arg1,
>      argo_dprintk("->do_argo_message_op(%d,%p,%p,%d,%d)\n", cmd,
>                   (void *)arg1.p, (void *)arg2.p, (int) arg3, (int) arg4);
>  
> +    if ( unlikely(!opt_argo_enabled) )
> +    {
> +        rc = -ENOSYS;
> +        argo_dprintk("<-do_argo_message_op()=%ld\n", rc);

While I can see debugging printk()s to be useful in certain places,
I question the utility of this and the other one. I also question the
use of -ENOSYS - I think you mean e.g. -EOPNOTSUPP.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel