[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 08/25] xen: define XEN_GUEST_HANDLE_NULL as null XEN_GUEST_HANDLE

>>> On 01.12.18 at 02:32, <christopher.w.clark@xxxxxxxxx> wrote:
> Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>

Here and elsewhere: Such additions, which we've found no need for
till now, should not be submitted without giving a reason for why
they become necessary or at least desirable.

> --- a/xen/include/public/xen.h
> +++ b/xen/include/public/xen.h
> @@ -982,6 +982,8 @@ typedef struct {
>  #define XEN_GUEST_HANDLE_64(name) XEN_GUEST_HANDLE(name)
>  #endif
> +#define XEN_GUEST_HANDLE_NULL(name) (XEN_GUEST_HANDLE(name)){(name *)0}

Public headers are intended to be usable in C89 mode. While this
won't cause compilation to fail when not used, it still is a violation
of this principle. Furthermore the construct is incompletely


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.