Re: [Xen-devel] [PATCH v3 1/4] amd-iommu: add flush iommu_ops

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.12.18 at 12:29, <paul.durrant@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/amd/iommu_map.c
> +++ b/xen/drivers/passthrough/amd/iommu_map.c
> @@ -634,6 +634,56 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t dfn)
>      spin_unlock(&hd->arch.mapping_lock);
>  
>      amd_iommu_flush_pages(d, dfn_x(dfn), 0);
> +    return 0;
> +}
> +
> +static unsigned long flush_count(unsigned long dfn, unsigned int page_count,
> +                                 unsigned int order)
> +{
> +    unsigned long start = dfn >> order;
> +    unsigned long end = (dfn + page_count - 1) >> 1;

Granted in my earlier reply I had a missing opening parenthesis,
but the above is pretty clearly the wrong way of addressing
the resulting build error.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel