Re: [Xen-devel] [PATCH v3 1/4] amd-iommu: add flush iommu_ops

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 05 December 2018 11:46
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Brian Woods <brian.woods@xxxxxxx>; Suravee Suthikulpanit
> <suravee.suthikulpanit@xxxxxxx>; Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau Monne <roger.pau@xxxxxxxxxx>; Wei
> Liu <wei.liu2@xxxxxxxxxx>; xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3 1/4] amd-iommu: add flush iommu_ops
> 
> >>> On 05.12.18 at 12:29, <paul.durrant@xxxxxxxxxx> wrote:
> > --- a/xen/drivers/passthrough/amd/iommu_map.c
> > +++ b/xen/drivers/passthrough/amd/iommu_map.c
> > @@ -634,6 +634,56 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t
> dfn)
> >      spin_unlock(&hd->arch.mapping_lock);
> >
> >      amd_iommu_flush_pages(d, dfn_x(dfn), 0);
> > +    return 0;
> > +}
> > +
> > +static unsigned long flush_count(unsigned long dfn, unsigned int
> page_count,
> > +                                 unsigned int order)
> > +{
> > +    unsigned long start = dfn >> order;
> > +    unsigned long end = (dfn + page_count - 1) >> 1;
> 
> Granted in my earlier reply I had a missing opening parenthesis,
> but the above is pretty clearly the wrong way of addressing
> the resulting build error.

Sorry, that's way too cryptic. What build error?

  Paul

> 
> Jan
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel