Re: [Xen-devel] [PATCH] x86/hvm/viridian: stop open coding updates to APIC registers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.12.18 at 15:57, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Paul Durrant
>> Sent: 10 December 2018 14:57
>> 
>> > From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> > Sent: 10 December 2018 13:44
>> >
>> > >>> On 07.12.18 at 18:50, <paul.durrant@xxxxxxxxxx> wrote:
>> > > The code in viridian_synic_wrmsr() duplicates logic in
>> > vlapic_reg_write()
>> > > to update the ICR, ICR2 and TASKPRI registers. Instead of doing this,
>> > > make vlapic_reg_write() non-static and call it.
>> >
>> > There's a side effect from this change, which I think should be called
>> > out since perhaps it's actually a (minor) bug fix: vlapic_reg_write()
>> > clears out vlapic->loaded, which the open coded Viridian code didn't
>> > do.
>> >
>> 
>> Yes, that was an anomaly and did look wrong.
>> 
>> > If it wasn't for this, I would have been uncertain whether exposing a
>> > function that really was meant to be vlapic.c-internal is a good idea.
>> >
>> 
>> Unfortunately the way that Microsoft specify the SynIC (as a "superset of
>> the local APIC") means that the code does need to be closely tied. Do you
>> want me to formulate a comment and submit a v2, or are you happy to add a
>> comment on commit?
> 
> Oh, I see Andrew already committed it.

Right, and if anything it would have been an addition to the
description, so there's no point submitting any incremental
patch.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel