Re: [Xen-devel] [RFC 11/16] irq: skip action avalability check for guest's IRQ

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

Julien,


On 12.12.18 13:59, Julien Grall wrote:
> An ASSERT(...) is already embed in irq_get_guest_info(desc).
Yep.

> I thought about the ASSERT(...) over the current printk yesterday. But I 
> discarded it because it does not give you more information if something went 
> really wrong as the stack trace would not really be helpful in that context.
But ASSERT also prints a failed condition text.

> So I would prefer the #ifdef NDEBUG solution.
I'm a bit confused about your suggestion.
Do you want to see two identical pieces of code before and after the `if ( 
test_bit(_IRQ_GUEST, &desc->status) )`? One with `#ifndef NDEBUG`, other 
without.
Is my understanding correct?


--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel