|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/4] x86/passthrough: move io.c to the x86 subfolder
On Fri, Jan 04, 2019 at 10:03:21AM -0700, Jan Beulich wrote: > >>> On 04.01.19 at 11:33, <roger.pau@xxxxxxxxxx> wrote: > > It makes no sense for io.c to be on the top level passthrough > > directory, since it's x86 specific. > > I'm not sure it really is. It's largely about interrupt arrangements > for guests, which (being PCI-related) may or may not be re- > usable by Arm once they get to support PCI. The file makes heavy usage of x86 only constructs, like hvm_pirq_dpci, hvm_irq_dpci and a lot of x86 specific HVM functions. This could indeed be used by ARM in the future if such functions and structures are implemented on ARM, but it would certainly require a non-trivial amount of changes to this file and other code. As it stands now this code is x86 specific, and as such it makes more sense IMO to reside in the x86 sub-folder. I agree it makes sense to rename, maybe x86/irq.c or x86/interrupt.c? Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |