[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 03/15] argo: define argo_dprintk for subsystem debugging
>>> On 07.01.19 at 08:42, <christopher.w.clark@xxxxxxxxx> wrote: > A convenience for working on development of the argo subsystem: > setting a #define variable enables additional debug messages. > > Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> with one further remark: > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -19,6 +19,15 @@ > #include <xen/errno.h> > #include <xen/guest_access.h> > > +/* Change this to #define ARGO_DEBUG here to enable more debug messages */ > +#undef ARGO_DEBUG > + > +#ifdef ARGO_DEBUG > +#define argo_dprintk(format, args...) printk("argo: " format, ## args ) > +#else > +#define argo_dprintk(format, ... ) ((void)0) This would better be an inline function, such that arguments passed in actually get evaluated. Otherwise you risk overlooking variables used for such logging only, and in particular the compiler then issuing warnings (breaking the build due to -Werror). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |