Re: [Xen-devel] [PATCH v3 03/15] argo: define argo_dprintk for subsystem debugging

[Roger Pau Monné <royger@xxxxxxxxxxx>]

On Mon, Jan 7, 2019 at 8:43 AM Christopher Clark
<christopher.w.clark@xxxxxxxxx> wrote:
>
> A convenience for working on development of the argo subsystem:
> setting a #define variable enables additional debug messages.
>
> Signed-off-by: Christopher Clark <christopher.clark6@xxxxxxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> v2 #03 feedback, Jan: fix ifdef/define confusion error
> v1 #04 feedback, Jan: fix dprintk implementation
>
>  xen/common/argo.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/xen/common/argo.c b/xen/common/argo.c
> index d69ad7c..6f782f7 100644
> --- a/xen/common/argo.c
> +++ b/xen/common/argo.c
> @@ -19,6 +19,15 @@
>  #include <xen/errno.h>
>  #include <xen/guest_access.h>
>
> +/* Change this to #define ARGO_DEBUG here to enable more debug messages */
> +#undef ARGO_DEBUG
> +
> +#ifdef ARGO_DEBUG
> +#define argo_dprintk(format, args...) printk("argo: " format, ## args )

I would maybe consider prefixing this with XENLOG_DEBUG, but since
it's a hidden compile-time debug I'm not sure it's relevant to set the
log level.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel