Re: [Xen-devel] [OSSTEST PATCH 1/3] ts-livepatch-run: Treat (just) falseish from OutputCheck as fail

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Jan 16, 2019 at 11:36:35AM +0000, Ian Jackson wrote:
> This is more idiomatic.  All existing OutputChecks return booleans, so
> no functional change.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Thank you!
> ---
>  ts-livepatch-run | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ts-livepatch-run b/ts-livepatch-run
> index f1194586..8fdb8004 100755
> --- a/ts-livepatch-run
> +++ b/ts-livepatch-run
> @@ -147,8 +147,8 @@ sub livepatch_test () {
>          }
>          if (defined($test->{OutputCheck})) {
>              $_ = $output;
> -            $rc=$test->{OutputCheck}->();
> -            if ($rc ne 1) {
> +            my $ok = $test->{OutputCheck}->();
> +            if (!$ok) {
>                  die "FAILED! OutputCheck=$test->{OutputCheck}, 
> input=$output\n";
>              }
>          }
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel