Re: [Xen-devel] [PATCH] iommu: specify page_count rather than page_order to iommu_map/unmap()...

[Julien Grall <julien.grall@xxxxxxx>]

On 18/01/2019 16:03, Paul Durrant wrote:
> ...and remove alignment assertions.
>
> Testing shows that certain callers of iommu_legacy_map/unmap() specify
> order > 0 ranges that are not order aligned thus causing one of the
> IS_ALIGNED() assertions to fire.
>
> This patch removes those assertions and modifies iommu_map/unmap() and
> iommu_legacy_map/unmap() to take a page_count argument rather than a
> page_order. Using a count actually makes more sense because the valid
> set of mapping orders is specific to the IOMMU implementation and to it
> should be up to the implementation specific code to translate a mapping
> count into an optimal set of mapping orders (when the code is finally
> modified to support orders > 0).
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> ---
> Reported-by: Chao Gao <chao.gao@xxxxxxxxx>
> Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
You put those tags after ---. Don't you want them in the final commit?

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel