[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] iommu: specify page_count rather than page_order to iommu_map/unmap()...
> -----Original Message----- > From: Julien Grall [mailto:julien.grall@xxxxxxx] > Sent: 18 January 2019 16:07 > To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx > Cc: Chao Gao <chao.gao@xxxxxxxxx>; Sander Eikelenboom > <linux@xxxxxxxxxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Andrew Cooper > <Andrew.Cooper3@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Roger Pau > Monne <roger.pau@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; > Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Konrad Rzeszutek Wilk > <konrad.wilk@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Tim > (Xen.org) <tim@xxxxxxx>; Jun Nakajima <jun.nakajima@xxxxxxxxx>; Kevin Tian > <kevin.tian@xxxxxxxxx> > Subject: Re: [PATCH] iommu: specify page_count rather than page_order to > iommu_map/unmap()... > > > > On 18/01/2019 16:03, Paul Durrant wrote: > > ...and remove alignment assertions. > > > > Testing shows that certain callers of iommu_legacy_map/unmap() specify > > order > 0 ranges that are not order aligned thus causing one of the > > IS_ALIGNED() assertions to fire. > > > > This patch removes those assertions and modifies iommu_map/unmap() and > > iommu_legacy_map/unmap() to take a page_count argument rather than a > > page_order. Using a count actually makes more sense because the valid > > set of mapping orders is specific to the IOMMU implementation and to it > > should be up to the implementation specific code to translate a mapping > > count into an optimal set of mapping orders (when the code is finally > > modified to support orders > 0). > > > > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx> > > --- > > Reported-by: Chao Gao <chao.gao@xxxxxxxxx> > > Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx> > You put those tags after ---. Don't you want them in the final commit? > Good point. If there is a v2 then I'll move them, otherwise I hope that can be fixed up on commit. Paul > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |