Re: [Xen-devel] [PATCH v2 4/8] viridian: add missing context save helpers into synic and time modules

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Paul Durrant <paul.durrant@xxxxxxxxxx> 01/08/19 4:18 PM >>>
>Currently the time module lacks vcpu context save helpers and the synic
>module lacks domain context save helpers. These helpers are not yet
>required but subsequent patches will require at least some of them so this
>patch completes the set to avoid introducing them in an ad-hoc way.

But they're introduced without callers - as they do nothing right now,
wouldn't it be better to add the call sites right here, for them to not
later get added - as you say - in an ad hoc way?


--- a/xen/arch/x86/hvm/viridian/synic.c
+++ b/xen/arch/x86/hvm/viridian/synic.c
@@ -179,6 +179,17 @@ void viridian_synic_load_vcpu_ctxt(
     v->arch.hvm.viridian->apic_assist_pending = ctxt->apic_assist_pending;
 }
 
+void viridian_synic_save_domain_ctxt(
+    const struct domain *d, struct hvm_viridian_domain_context *ctxt)
+{
+}
+
+void viridian_synic_load_domain_ctxt(
+    struct domain *d, const struct hvm_viridian_domain_context *ctxt)
+{
+}
+
+
 /*

Would you mind avoiding the double blank loine insertion here?


Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel