Re: [Xen-devel] [PATCH v2 4/8] viridian: add missing context save helpers into synic and time modules

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:jbeulich@xxxxxxxx]
> Sent: 29 January 2019 13:05
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau Monne
> <roger.pau@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 4/8] viridian: add missing context save helpers
> into synic and time modules
> 
> >>> Paul Durrant <paul.durrant@xxxxxxxxxx> 01/08/19 4:18 PM >>>
> >Currently the time module lacks vcpu context save helpers and the synic
> >module lacks domain context save helpers. These helpers are not yet
> >required but subsequent patches will require at least some of them so
> this
> >patch completes the set to avoid introducing them in an ad-hoc way.
> 
> But they're introduced without callers - as they do nothing right now,
> wouldn't it be better to add the call sites right here, for them to not
> later get added - as you say - in an ad hoc way?
> 

OK, I can do that.

> 
> --- a/xen/arch/x86/hvm/viridian/synic.c
> +++ b/xen/arch/x86/hvm/viridian/synic.c
> @@ -179,6 +179,17 @@ void viridian_synic_load_vcpu_ctxt(
>      v->arch.hvm.viridian->apic_assist_pending = ctxt-
> >apic_assist_pending;
>  }
> 
> +void viridian_synic_save_domain_ctxt(
> +    const struct domain *d, struct hvm_viridian_domain_context *ctxt)
> +{
> +}
> +
> +void viridian_synic_load_domain_ctxt(
> +    struct domain *d, const struct hvm_viridian_domain_context *ctxt)
> +{
> +}
> +
> +
>  /*
> 
> Would you mind avoiding the double blank loine insertion here?
> 

Oops, yes, that should have been cleaned up.

  Paul

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel