[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v1] xen/ACPI: Switch to bitmap_zalloc()



Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
---
 drivers/xen/xen-acpi-processor.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c
index fbb9137c7d02..a6089851628f 100644
--- a/drivers/xen/xen-acpi-processor.c
+++ b/drivers/xen/xen-acpi-processor.c
@@ -410,21 +410,21 @@ static int check_acpi_ids(struct acpi_processor 
*pr_backup)
        /* All online CPUs have been processed at this stage. Now verify
         * whether in fact "online CPUs" == physical CPUs.
         */
-       acpi_id_present = kcalloc(BITS_TO_LONGS(nr_acpi_bits), sizeof(unsigned 
long), GFP_KERNEL);
+       acpi_id_present = bitmap_zalloc(nr_acpi_bits, GFP_KERNEL);
        if (!acpi_id_present)
                return -ENOMEM;
 
-       acpi_id_cst_present = kcalloc(BITS_TO_LONGS(nr_acpi_bits), 
sizeof(unsigned long), GFP_KERNEL);
+       acpi_id_cst_present = bitmap_zalloc(nr_acpi_bits, GFP_KERNEL);
        if (!acpi_id_cst_present) {
-               kfree(acpi_id_present);
+               bitmap_free(acpi_id_present);
                return -ENOMEM;
        }
 
        acpi_psd = kcalloc(nr_acpi_bits, sizeof(struct acpi_psd_package),
                           GFP_KERNEL);
        if (!acpi_psd) {
-               kfree(acpi_id_present);
-               kfree(acpi_id_cst_present);
+               bitmap_free(acpi_id_present);
+               bitmap_free(acpi_id_cst_present);
                return -ENOMEM;
        }
 
@@ -593,8 +593,8 @@ static void __exit xen_acpi_processor_exit(void)
 
        unregister_syscore_ops(&xap_syscore_ops);
        kfree(acpi_ids_done);
-       kfree(acpi_id_present);
-       kfree(acpi_id_cst_present);
+       bitmap_free(acpi_id_present);
+       bitmap_free(acpi_id_cst_present);
        kfree(acpi_psd);
        for_each_possible_cpu(i)
                acpi_processor_unregister_performance(i);
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.