Re: [Xen-devel] bogus libxl error handling in domcreate_bootloader_done

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 04, 2019 at 05:17:06PM +0100, Olaf Hering wrote:
> Am Mon, 4 Mar 2019 14:54:01 +0000
> schrieb Wei Liu <wei.liu2@xxxxxxxxxx>:
> 
> > > > +    /* Prepare environment for domcreate_stream_done */
> > > > +    dcs->srs.ao = ao;
> > > > +    dcs->srs.dcs = dcs;
> > > > +    dcs->srs.fd = -1;
> > As far as I can tell only srs.dcs needs to be initialised before hand.
> 
> fd needs to be tweaked as well to prevent the "soft reset" code path.
> But as I notice just now, my change touches the wrong fd. restore_fd
> is apparently already set. So yes, only dcs is required.
> 
> But is domcreate_bootloader_done the correct place to initialize it?

/me wonders the same.

I'm puzzled by the code as well.  Ian, what do you think?

Wei.

> 
> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel