Re: [Xen-devel] [PATCH v2] x86: don't allow clearing of TF_kernel_mode for other than 64-bit PV

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Mar 11, 2019 at 10:37:44AM -0600, Jan Beulich wrote:
> The flag is really only meant for those, both HVM and 32-bit PV tell
> kernel from user mode based on CPL/RPL. Remove the all-question-marks
> comment and let's be on the safe side here and also suppress clearing
> for 32-bit PV (this isn't a fast path after all).
> 
> Remove no longer necessary is_pv_32bit_*() from sh_update_cr3() and
> sh_walk_guest_tables(). Note that shadow_one_bit_disable() already
> assumes the new behavior.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel