Re: [Xen-devel] [PATCH v5 02/11] viridian: separately allocate domain and vcpu structures

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.03.19 at 14:41, <paul.durrant@xxxxxxxxxx> wrote:
> Currently the viridian_domain and viridian_vcpu structures are inline in
> the hvm_domain and hvm_vcpu structures respectively. Subsequent patches
> will need to add sizable extra fields to the viridian structures which
> will cause the PAGE_SIZE limit of the overall vcpu structure to be
> exceeded. This patch, therefore, uses the new init hooks to separately
> allocate the structures and converts the 'viridian' fields in hvm_domain
> and hvm_cpu to be pointers to these allocations. These separate allocations
> also allow some vcpu and domain pointers to become const.
> 
> Ideally, now that they are no longer inline, the allocations of the
> viridian structures could be made conditional on whether the toolstack
> is going to configure the viridian enlightenments. However the toolstack
> is currently unable to convey this information to the domain creation code
> so such an enhancement is deferred until that becomes possible.
> 
> NOTE: The patch also introduced the 'is_viridian_vcpu' macro to avoid
>       introducing a second evaluation of 'is_viridian_domain' with an
>       open-coded 'v->domain' argument. This macro will also be further
>       used in a subsequent patch.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Non-Viridian parts
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel