Re: [Xen-devel] [PATCH for-next 5/9] xen: Convert hotplug page function to use typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 13/03/2019 14:57, Jan Beulich wrote:
> > > > On 18.02.19 at 12:35, <julien.grall@xxxxxxx> wrote:
> > Convert online_page, offline_page and query_page_offline to use
> > typesafe MFN.
> >
> > No functional changes.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> But ...
>
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -1568,23 +1568,23 @@ static int reserve_heap_page(struct page_info *pg)
> >   
> >   }
> >   
> > -int offline_page(unsigned long mfn, int broken, uint32_t *status)
> > +int offline_page(mfn_t mfn, int broken, uint32_t *status)
> >   {
> >       unsigned long old_info = 0;
> >       struct domain *owner;
> >       struct page_info *pg;
> >   
> > -    if ( !mfn_valid(_mfn(mfn)) )
> > +    if ( !mfn_valid(mfn) )
> >       {
> >           dprintk(XENLOG_WARNING,
> > -                "try to offline page out of range %lx\n", mfn);
> > +                "try to offline page out of range %"PRI_mfn"\n", mfn_x(mfn));
> ... would you mind adjusting the wording here as well:
> "attempt to offline out of range page %"PRI_mfn"\n" or > some such?
Sure.

> Of course the usefulness of the message as a whole is
> questionable, so I'd also be happy to see it deleted altogether.
While I am happy to do formatting, I would rather leave code removal in separate 
patch.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel