[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors



>>> On 13.03.19 at 20:37, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/tools/misc/xen-cpuid.c
> +++ b/tools/misc/xen-cpuid.c
> @@ -127,6 +127,8 @@ static const char *str_7c0[32] =
>      [14] = "avx512_vpopcntdq",
>  
>      [22] = "rdpid",
> +
> +    [30] = "sgx-lc",
>  };
>  
>  static const char *str_e7d[32] =

Hmm, to be honest I don't see why this needs to go in ahead of
https://lists.xenproject.org/archives/html/xen-devel/2018-12/msg01813.html
posted almost 3 months ago, and already taking care of the bit.
I'm fine to switch from underscore to dash there if that's
desired, but it looks inconsistent with pre-existing entries (as
the context of your patch also shows).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.