Re: [Xen-devel] [PATCH] x86/MCE: mcequirk stuff is AMD-specific

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.19 at 16:43, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/03/2019 12:46, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/arch/x86/cpu/mcheck/mce_amd.c
>> +++ b/xen/arch/x86/cpu/mcheck/mce_amd.c
>> @@ -70,12 +70,22 @@
>>  #include "x86_mca.h"
>>  #include "mce_amd.h"
>>  #include "mcaction.h"
>> -#include "mce_quirks.h"
>>  #include "vmce.h"
>>  
>> -#define ANY -1
>> +#define ANY (~0U)
>>  
>> -static const struct mce_quirkdata mce_amd_quirks[] = {
>> +enum mcequirk_amd_flags {
>> +    MCEQUIRK_NONE,
>> +    MCEQUIRK_K8_GART,
>> +    MCEQUIRK_F10_GART
> 
> Seeing as you're modifying this, mind adding a trailing comma just in
> case it needs extending in the future?

Oh, sure - simply an oversight (or habit from private projects,
where I don't normally do this).

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel