Re: [Xen-devel] [PATCH v7 10/11] viridian: add implementation of synthetic timers

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 15 March 2019 16:17
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>; Andrew Cooper 
> <Andrew.Cooper3@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Roger Pau 
> Monne
> <roger.pau@xxxxxxxxxx>; Wei Liu <wei.liu2@xxxxxxxxxx>; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>;
> xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>; Konrad Rzeszutek Wilk 
> <konrad.wilk@xxxxxxxxxx>; Tim
> (Xen.org) <tim@xxxxxxx>
> Subject: RE: [PATCH v7 10/11] viridian: add implementation of synthetic timers
> 
> >>> On 15.03.19 at 16:40, <Paul.Durrant@xxxxxxxxxx> wrote:
> > So, AIUI the reason you wanted it added was that you wanted to avoid
> > multiple calls hvm_vcpu_has_pending_irq() from returning different intack
> > values? But looking again, this could easily happen if a higher irr bit gets
> > set between calls (which can apparently happen asynchronously) so I'm really
> > no longer sure why I need to avoid multiple polls. What is the problem that
> > needs to be avoided?
> 
> Hmm, true. Looks like I've mis-guided you, I'm sorry for that.
> 

Ok. I'll send a follow-up patch to pull it out, and I've also just now found a 
mistake in the handling of absolute timers so I'll send a patch for that too.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel