[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers
- To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>, 'Jan Beulich' <JBeulich@xxxxxxxx>
- From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
- Date: Mon, 18 Mar 2019 15:46:23 +0000
- Accept-language: en-GB, en-US
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Mar 2019 15:49:06 +0000
- Ironport-data: A9a23:LAUETquNbdB6j952HbjFOmIBMOfnOphVZqmSV/efNr3fP3i5XxfKXv tXStiZWroQMLXHkFql0fSA2ceOjfSlSMg/fIwhYHBkQIWLWNuV+DshLEZtvZ7X8T20kWfGof wf9hYApCvVrMyaxl35pCQK9PLIIoQxWogS/3a7MB7LvbbljENKB8vEP2HwtYY/+71kMKHrEy FsdxCShWzmnQqQK4obsEQ6tfylczF4Bon6icmeBv7APbOV67j3CvXL+AsxDpdA4vrdRtRvww oot0fSJ60YGqI3P7IARaiUy11WtHdLwje0OX870MKxwoRW+rcmNHKbasYZyrWomFxXiA0Cw/ gC06hcPyi57KPfK3zHuPkY9yVxn98u1W4aHSWFmcyLa4ct4pcAcgsHWWDbt8jcTRjkpwHiXl XIBhx5A/sioC8ytbH432km9JJW0grNVsCb39838avgVQCs8O8tGYHeE9hXZKoUJccMNPjhtE HLgmplMnWUU+v7xLDSiALgmyrVUUcsobCEe2sIc6qD3f88IGaejFsLHbl4fLB8aTsLJ5mfET B7679dBDJbPFs/OyACElufhyADJEeHU2gX+ftdnJsDvefIag7Z+j79vlstO2crVtcm8LX4XL He4XYBX7dCpiPppQ1EE2mx9FSU3LtW32TMJuQoTW9At9fOcLfra72UbC0QeliVSk2wUxR4Mx dL6JJAqTgdlOQPh2bnB2l+80qtiamnHdlZfhAf78PGrxkzcZLYiMLseaHlytLYdZVXpaoGF3 U8DGZr+DqCFENOT5MNcsVkCAlxAK57U1DycCEpMahpo4S3Vp0/cgkN7RYk3D9/rK1eUJR7Vq y3mQ1oH6podILRKY+AVnGGyAnFPK0mwTOOMieaFXMiMAhwump7hvypsGQF0MLYfHP/db4AhX 8FQ0fwmH542/fGy2hLon1fpQ3g1M25F3GZrIfCgHP5uGxRuvj63RU67zc9u3i2zOlq6SaVM5 lzuo86b/wVnEyw/TjEZIQNvkGUKI1VMynCx0mrMvksAosXA9aeKyeqSsPwCwVIqkvTgzu7be XXJMGbGRo+yArHRbOqO2wThQ8G9iAX7PqnwtjHTJsbLV1nfvUqhauuO1hXi7nC0OXZYXKMwq /WfK2yTvI4xvZjpMLDHfiwQlvjKcDvhKHpMjVJrn2JR3Bo2YmYxvuvYHWs8qOfv4E1jpngKn 1y5w3RUQ+/W1kp6TDrIDhSzBZn18RViPjfaaICSL87SJwKGV2uZ+YlshmG6qeME+Sm+ygycv JxogdrVieE5YsQGx0uNNxXqLgq2eDUzrvot/xxjzbBC4UbgRSPHju1wmN7v7Qlb2opC1XMp5 Z+lxt/t0sElBnHF0LCZWesmNIhOj5Waar9ZcFIvgHa50ReN3w7ku/TAwbva9CqL/hzak7s8l liMed+olyKF/AVH+VoRGOe6of/TiyrUwjbi6f00NWFxIu5e2F5rXo5urbwUWBqWvqOkvIJkG ZHDU3GuRNSy5W5IWvlQZgnsRMtmqKg/bRK0zwqr9099u8MfOML2hXFbC842Ts6s4CKYpi8PE QsMEFFP5Q7FgO18/YQ6TZNHMxSBavDikbgoQwRFJV+2pZEPuYl8zCViviiMgEr9r/4XVZ9Cy gsPyed0U1fUToMnG7GIx66QchU0hyjgsuDeyA1usfYLm2JE9yhYYHC6iYn63oIbfJ6sX2/Bs 8+JL3Ss0F5xq4wkiLRqTc2wt6nO3i6BCnmu9xrEPhHxEBu4WRKs6LwNXdMbejkZfRM7C2epn FTfN8q/NsD4pZNXBPmNvVZ7HW0f8t1rJ5X2e0fMNlMoCS5+kI2FdI9ZLPj3UtcJH4mDJXUEN jiLHwmN2zvINnDJJiyTAQZJqsCWeQTy4uJn/UzbJ7+M8Kx//zyWit+sfRUF6d2kOIWeTW22B zZvfxUBv4PvMBbF3UWzmX0sKzPJsQfw8q7vKwAI1LbjxmMHPhgZoJpF6utKggf9fZnwpVX+Y J0ERxKeYChinJOiZbeSNEhIWQLfVyzav7vvTlgyOPBvCEsGgHwOx6OL37wW9IQl/34ZxRmUY UazpyYbUrIkmH74MFcvsLnZm3c
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHU3X2WVMvWAzv7yUWT06FGctY0sqYRYLYAgAATJKCAABN4MA==
- Thread-topic: [Xen-devel] [PATCH v8 10/11] viridian: add implementation of synthetic timers
> -----Original Message-----
[snip]
> > > + {
> > > + expiration = vs->count;
> > > + if ( expiration - now <= 0 )
> > > + {
> > > + vs->expiration = expiration;
> > > + stimer_expire(vs);
> >
> > Aren't you introducing a risk for races by calling the timer function
> > directly from here? start_timer(), after all, gets called from quite a
> > few places.
> >
>
> In practice I don't think there should be any problematic race, but I'll
> check again.
>
I think the 'periodic' name might be confusing things... The Xen timers are all
single-shot, it's just that start_stimer() is re-called after a successful poll
if the viridian timer is configured to be periodic. So I don't think there is
case where the underlying Xen timer could actually be running when we enter
start_stimer().
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
