Re: [Xen-devel] [PATCH RFC 05/55] x86/mm: introduce l{1, 2}t local variables to modify_xen_mappings

["Nuernberger, Stefan" <snu@xxxxxxxxx>]

On Thu, 2019-02-07 at 16:44 +0000, Wei Liu wrote:
> The pl2e and pl1e variables are heavily (ab)used in that
> function.  It
> is fine at the moment because all page tables are always mapped so
> there is no need to track the life time of each variable.
> 
> We will soon have the requirement to map and unmap page tables. We
> need to track the life time of each variable to avoid leakage.
> 
> Introduce some l{1,2}t variables with limited scope so that we can
> track life time of pointers to xen page tables more easily.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Same remark as Jan on the previous patch, some of the original
pl1e/pl2e usage is retained. I don't see yet how this scoping will
later help with map/unmap, but I'd also prefer if all usage was scoped
and the function-scope pl1e/pl2e removed.

- Stefan



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel