Re: [Xen-devel] [PATCH] xen: passthrough/amd: Remove unused function guest_iommu_set_base

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 3/20/19 11:13 AM, Andrew Cooper wrote:
> On 19/03/2019 23:20, Julien Grall wrote:
> > The function is unused and could potentially lead a to trigger the
> > BUG_ON() in p2m_change_type_one if misused as the p2m type is not
> > sanitized.
> >
> > So remove it.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Either the entire file goes, or this function stays.  It definitely
> isn't production ready yet, as noted in my post-commit notes in
> https://lists.xenproject.org/archives/html/xen-devel/2018-11/msg02356.html
I should have probably looked at the commit logs first :). I found it 
while looking whether we can re-use p2m_change_type_one on Arm too.
> However, this functionality is going to be necessary in the future.  It
> is probably easier just to leave it as-is.
I will drop the patch then.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel