Re: [Xen-devel] [PATCH] xen: passthrough/amd: Remove unused function guest_iommu_set_base

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 3/20/19 7:05 AM, Jan Beulich wrote:
> > > > Julien Grall <julien.grall@xxxxxxx> 03/20/19 12:21 AM >>>
> > The function is unused and could potentially lead a to trigger the
> > BUG_ON() in p2m_change_type_one if misused as the p2m type is not
> > sanitized.
> >
> > So remove it.
> I don't think I agree - the entire file is effectively unused, and hence 
> removal should
> perhaps be an all-or-nothing action. But let's see what the maintainers say.
Based on Andrew comments, I will dropped the patch for now.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel