Re: [Xen-devel] [PATCH 4/6] xen: don't free percpu areas during suspend

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.03.19 at 08:53, <jgross@xxxxxxxx> wrote:
> On 28/03/2019 08:46, Jan Beulich wrote:
>>>>> On 18.03.19 at 14:11, <jgross@xxxxxxxx> wrote:
>>> Instead of freeing percpu areas during suspend and allocating them
>>> again when resuming keep them. Only free an area in case a cpu didn't
>>> come up again when resuming.
>> 
>> There's another aspect here which needs at least mentioning:
>> Right now, CPUs coming back up have their per-CPU data
>> cleared. Not doing so may indeed be an improvement in
>> some cases (like statistics collected), but may also get in the
>> way in other cases.
> 
> I have checked the respective cpu notifier hooks and I think this is no
> problem. I hope I didn't overlook something.

Is checking the hooks sufficient? I'd rather expect we need to
check all per-CPU data objects.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel