Re: [Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.04.19 at 09:56, <wipawel@xxxxxxxxx> wrote:
> The symbols tool is outdated and has a bug in it leading to crashes.
> The tool is derived from linux kernel where this bug has been already
> fixed.

Thanks for noticing this omission of ours.

> Original linux kernel commit:
> e0a04b11e4059cab033469617 scripts/kallsyms.c: fix potential segfault
> 
> Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
> Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
> Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>

When we pull in changes (almost) verbatim from Linux, we typically
retain original authorship as well as the (possibly massaged)
title and description. See xen/arch/x86/cpu/mwait-idle.c's
history for some examples. I'll do this transformation before
committing the change, but in the future I'd appreciate if ported
patches were submitted that way.

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm btw also confused by the Cc list you've used: You should
have Cc-ed THE REST, not just the tool stack maintainers.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel