Re: [Xen-devel] [PATCH] xen/tools: Fix symbols segfaults

["Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>]

On 3. Apr 2019, at 10:10, Jan Beulich <JBeulich@xxxxxxxx> wrote:

On 03.04.19 at 09:56, <wipawel@xxxxxxxxx> wrote:

The symbols tool is outdated and has a bug in it leading to crashes.
The tool is derived from linux kernel where this bug has been already
fixed.

Thanks for noticing this omission of ours.

Anytime.

Original linux kernel commit:
e0a04b11e4059cab033469617 scripts/kallsyms.c: fix potential segfault

Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>

When we pull in changes (almost) verbatim from Linux, we typically
retain original authorship as well as the (possibly massaged)
title and description. See xen/arch/x86/cpu/mwait-idle.c's
history for some examples. I'll do this transformation before
committing the change, but in the future I'd appreciate if ported
patches were submitted that way.

Sure, I will be submitting patches that way.

It might make sense to add this explanation into the CONTRIBUTING

file to avoid this problem in the future (unless it documented already

somewhere and I simply missed it).

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm btw also confused by the Cc list you've used: You should
have Cc-ed THE REST, not just the tool stack maintainers.

You’re right. My bad. Sorry.

Jan

Best Regards,
Pawel Wieczorkiewicz

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
Ust-ID: DE 289 237 879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel