Re: [Xen-devel] [PATCH for-next 4/9] xen/grant-table: Make arch specific macros typesafe

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 4/15/19 11:03 PM, Stefano Stabellini wrote:
> On Mon, 18 Feb 2019, Julien Grall wrote:
> > No functional changes intended.
> Please list here the changes this patch is making:
>
> - renaming gnttab_shared_gmfn to gnttab_shared_gfn to follow the naming
>    convention (and others.)
Ok for this but...

> - making gnttab_shared_gmfn returning gfn_t
... it does not make sense to mention one macro and not all the other 
that was modified because of the change. This is also already pretty 
clear from the commit title that all macros will be typesafe.
So I would rather not mention this.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel