Re: [Xen-devel] [PATCH for-next 8/9] xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 13 Mar 2019, Jan Beulich wrote:
> > @@ -215,6 +216,9 @@ void __hwdom_init iommu_hwdom_init(struct domain *d)
> >          /* Use while-break to avoid compiler warning */
> >          while ( iommu_iotlb_flush_all(d, flush_flags) )
> >              break;
> > +#else
> > +        rc = -ENOSYS;
> 
> -EOPNOTSUPP please.

The patch is fine by me and I am also fine with Jan's comments.

I only want to point out that we haven't been entirely consistent with
-ENOSYS and/or -EOPNOTSUPP. We have lots of places that return -ENOSYS.
Should we change them to -EOPNOTSUPP going forward?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel