Re: [Xen-devel] [PATCH V4 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces

[Oleksandr <olekstysh@xxxxxxxxx>]

On 29.04.19 17:29, Julien Grall wrote:
> Hi Oleksandr,
Hi Julien


> > ---
> >   docs/misc/arm/early-printk.txt    |  6 ++++++
> >   xen/arch/arm/Rules.mk             |  7 +++++++
> >   xen/arch/arm/arm32/debug-scif.inc | 13 +++++++++----
> >   3 files changed, 22 insertions(+), 4 deletions(-)
> >
> > diff --git a/docs/misc/arm/early-printk.txt 
> > b/docs/misc/arm/early-printk.txt
> > index b23c54f..c054674 100644
> > --- a/docs/misc/arm/early-printk.txt
> > +++ b/docs/misc/arm/early-printk.txt
> > @@ -27,6 +27,12 @@ 
> > CONFIG_EARLY_PRINTK=<INC>,<BASE_ADDRESS>,<OTHER_OPTIONS>
> >         If <BAUD_RATE> is not given then the code will not try to
> >         initialize the UART, so that bootloader or firmware settings can
> >        be used for maximum compatibility.
> > +  - scif,<BASE_ADDRESS>,<VERSION>
> > +    - <VERSION> is a option to choose which interface version should 
> > be used
> By "a option" did you intend to mean it is an optional parameter?
>
> If so, how about:
>
> "SCIF<VERSION> is, optionally, the interface version of the UART."
agree. will change.


> So you would also provide a way for the user to know how to specify 
> it. Stefano any opinion?
I am going to update Wiki page regarding how to run Stout board on Xen 
and how to properly enable earlyprintk support on that board.
Would it be enough? Also I can add a note to patch description.

In V1 I added convenient alias EARLY_PRINTK_stout, but AFAIR it was 
decided to avoid adding new aliases.

> > +      If <VERSION> is not given then a default interface version (SCIF)
> s/a/the/
ok



--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel