[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4 5/5] xen/arm: Add early printk support for SCIFA compatible UARTs




On 29.04.19 17:30, Julien Grall wrote:
Hi Oleksandr,

Hi, Julien


@@ -22,10 +22,13 @@
  #ifdef EARLY_PRINTK_VERSION_NONE
  #define STATUS_REG    SCIF_SCFSR
  #define TX_FIFO_REG   SCIF_SCFTDR
+#elif EARLY_PRINTK_VERSION_A
+#define STATUS_REG    SCIFA_SCASSR
+#define TX_FIFO_REG   SCIFA_SCAFTDR
  #endif
    /*
- * SCIF UART wait UART to be ready to transmit
+ * Wait UART to be ready to transmit

This change and ...

   * rb: register which contains the UART base address
   * rc: scratch register
   */
@@ -37,7 +40,7 @@
  .endm
    /*
- * SCIF UART transmit character
+ * UART transmit character

... this one look like more a change for the previous than this one.

agree, will move to previous patch.

--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.