Re: [Xen-devel] [PATCH 05/20] xen/arm: Rework secondary_start prototype

[Julien Grall <julien.grall@xxxxxxx>]

On 03/05/2019 16:56, Andrii Anisov wrote:
> Hello Julien,
>
> On 22.04.19 19:49, Julien Grall wrote:
> > None of the parameters of secondary_start are actually used. So turn
> > secondary_start to a function with no parameters.
> >
> > Also modify the assembly code to avoid setting-up the registers before
> > calling secondary_start.
> What is not really mandatory.
So...? You just don't setup parameter when it is not necessary. The more it is 
quite confusing for a reader to see the registers are setup but not used by the 
caller.
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Though:
>
> Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
Thank you.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel