Re: [Xen-devel] [PATCH 06/20] xen/arm: Remove parameter cpuid from start_xen

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 03/05/2019 16:56, Andrii Anisov wrote:
> On 22.04.19 19:49, Julien Grall wrote:
> > The parameter cpuid is not used by start_xen. So remove it.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > ---
> >   xen/arch/arm/arm32/head.S | 1 -
> >   xen/arch/arm/arm64/head.S | 1 -
> >   xen/arch/arm/setup.c      | 3 +--
> >   3 files changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> > index b71d7fb11d..9f40face98 100644
> > --- a/xen/arch/arm/arm32/head.S
> > +++ b/xen/arch/arm/arm32/head.S
> > @@ -448,7 +448,6 @@ launch:
> >           teq   r12, #0
> >           moveq r0, r10                /* Marshal args: - phys_offset */
> >           moveq r1, r8                 /*               - DTB address */
> > -        moveq r2, r7                 /*               - CPU ID */
> I don't really like making changes which are then fixed in next patches.
> I'd like to see it coupled this with the previous patch.
They are two different changes... one deal with start_xen the other deal with 
secondary_start.
I can offer to reshuffle the patches so this one is before #5, but not merge 
them.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel