Re: [Xen-devel] [PATCH 3/3] xen/arm: fix mask calculation in init_pdx

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.05.19 at 22:50, <sstabellini@xxxxxxxxxx> wrote:
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -481,10 +481,15 @@ static paddr_t __init next_module(paddr_t s, paddr_t 
> *end)
>  static void __init init_pdx(void)
>  {
>      paddr_t bank_start, bank_size, bank_end;
> -
> -    u64 mask = pdx_init_mask(bootinfo.mem.bank[0].start);
> +    u64 mask;
>      int bank;
>  
> +    /*
> +     * We always map the first 1<<MAX_ORDER of RAM, hence, they are left

"... pages of RAM." ?

> +     * uncompressed.
> +     */
> +    mask = pdx_init_mask(1ULL << (MAX_ORDER + PAGE_SHIFT));

PAGE_SIZE << MAX_ORDER?

I wonder whether pdx_init_mask() itself wouldn't better apply this
(lower) cap.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel