Re: [Xen-devel] [PATCH RFC V2 01/45] xen/sched: add inline wrappers for calling per-scheduler functions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.05.19 at 10:34, <jgross@xxxxxxxx> wrote:
> On 06/05/2019 10:27, Jan Beulich wrote:
>>>>> On 06.05.19 at 08:56, <jgross@xxxxxxxx> wrote:
>>> @@ -207,6 +250,141 @@ static inline void sched_free_domdata(const struct 
>>> scheduler *s,
>>>          ASSERT(!data);
>>>  }
>>>  
>>> +static inline void *sched_alloc_pdata(const struct scheduler *s, int cpu)
>>> +{
>>> +    if ( s->alloc_pdata )
>>> +        return s->alloc_pdata(s, cpu);
>>> +    else
>>> +        return NULL;
>>> +}
>> 
>> In cases like this one I'd like to ask that either ?: be used, or the 
>> pointless
>> "else" be dropped.
> 
> Fine with me. I guess adapting the already existing inline wrappers to
> that scheme with the same patch is okay?

I suppose so, unless that would grow the size of the patch
significantly.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel