[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/3] xen/arm: fix mask calculation in init_pdx



>>> On 07.05.19 at 15:20, <julien.grall@xxxxxxx> wrote:
> On 5/7/19 10:35 AM, Jan Beulich wrote:
>>>>> On 07.05.19 at 10:59, <julien.grall@xxxxxxx> wrote:
>>> At least on Arm, I don't see any real value to initialize the PDX mask
>>> with a base address. I would be more keen to implement pdx_init_mask() as:
>>>
>>> return fill_mask(((uint64_t)PAGE_SIZE << MAX_ORDER - 1);
>> 
>> But (besides the missing closing parenthese) that's not what x86 wants.
> 
> Could you remind me why?

Because we don't want to compress on the low 32 bits, for there
being "interesting" things below 4Gb.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.