Re: [Xen-devel] [PATCH V5 3/4] xen/arm: Extend SCIF early prink code to handle other interfaces

[Oleksandr <olekstysh@xxxxxxxxx>]

On 07.05.19 19:02, Julien Grall wrote:
> Hi,
Hi, Julien


> On 5/2/19 6:00 PM, Oleksandr Tyshchenko wrote:
> >   docs/misc/arm/early-printk.txt    |  5 +++++
> >   xen/arch/arm/Rules.mk             |  7 +++++++
> >   xen/arch/arm/arm32/debug-scif.inc | 17 +++++++++++------
> >   3 files changed, 23 insertions(+), 6 deletions(-)
> >
> > diff --git a/docs/misc/arm/early-printk.txt 
> > b/docs/misc/arm/early-printk.txt
> > index b23c54f..89e081e 100644
> > --- a/docs/misc/arm/early-printk.txt
> > +++ b/docs/misc/arm/early-printk.txt
> > @@ -27,6 +27,11 @@ 
> > CONFIG_EARLY_PRINTK=<INC>,<BASE_ADDRESS>,<OTHER_OPTIONS>
> >         If <BAUD_RATE> is not given then the code will not try to
> >         initialize the UART, so that bootloader or firmware settings can
> >        be used for maximum compatibility.
> > +  - scif,<BASE_ADDRESS>,<VERSION>
> > +    - SCIF<VERSION> is, optionally, the interface version of the UART.
> > +
> > +      If <VERSION> is not given then the default interface version 
> > (SCIF)
> > +      will be used.
> This patch now looks good. I would like some input from Stefano on the 
> wording here before it gets merged.
I understand. Thank you.


> Cheers,
--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel