Re: [Xen-devel] [PATCH RFC V2 02/45] xen/sched: use new sched_item instead of vcpu in scheduler interfaces

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Wed, 2019-05-08 at 17:35 +0100, George Dunlap wrote:
> On 5/6/19 7:56 AM, Juergen Gross wrote:
> > Rename the per-scheduler functions insert_vcpu and remove_vcpu to
> > insert_item and remove_item to reflect the change of the parameter.
> > In the schedulers rename local functions switched to sched_item,
> > too.
> > 
> > For now this new struct will contain a vcpu pointer only and is
> > allocated on the stack. This will be changed later.
> > 
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> 
> Oy, I realize this comment is going to be somewhat painful, but...
> 'item' really seems like the wrong word here.  To me 'item' always
> means
> one thing; whereas what you're planning on doing is grouping together
> vcpus to schedule together; which would mean "unit" (as in, a
> military
> unit).
> 
_If_ we're getting into this, I'd like to propose 'entity',
'sched_entity', etc. :-)

Perhaps it's because I'm used to it from Linux, but I really like it,
more than both sched_item and sched_unit.

In fact, the group of vcpus is the *entity* with which the scheduler
deals.

> I realize changing it here probably means also changing it in the
> next
> 43 patches as well.
> 
Indeed! :-O

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel